chore: update Binaryen #2927
chore: update Binaryen #2927
Conversation
|
|
| ) | ||
| (func $start:function-call~anonymous|2 (param $0 i32) (param $1 i32) (result i32) | ||
| local.get $0 | ||
| local.get $1 | ||
| i32.add | ||
| ) | ||
| (func $start:function-call~fn2|4 (param $0 i32) (result i32) | ||
| i32.const 1 | ||
| local.get $0 |
There was a problem hiding this comment.
Hmm, this definitely got worse.
There was a problem hiding this comment.
I believe these two cases are caused by the same issue (the dae/DeadArgumentElimination pass not doing its job? I'm not fully sure).
I did a bisection to find the Binaryen commit that's responsible. (I tested on the call-optional WAT file in S-expr format, but the issue applies here as well.) It looks like WebAssembly/binaryen#7135 is the cause, as that PR treats any funcref as being possibly leaked to the outside world...
How should we proceed? I don't think marking the module as closed-world is accurate...
Some new features are being added, although only relaxed SIMD is in a usable state. stringref has been almost obliterated, and only functionality compatible with JS string builtins is being kept. Binaryen also seems to be generating more nops and blocks than usual. Also, due to WebAssembly/binaryen#7135, dead arguments aren't being eliminated when a function reference is made (ref.func), which affects the optimized output of call-optional, function-call, and other tests.
Changes proposed in this pull request:
⯈ Updating Binaryen to v123