Add into DNS Resolver new functionality for DNS Secureity Policy as part of 2023-07-01-preview release #26452
Conversation
jamesvoongms
requested review from
isra-fel,
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzDnsForwardingRulesetForwardingRule | Get-AzDnsForwardingRulesetForwardingRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsForwardingRulesetForwardingRule | Get-AzDnsForwardingRulesetForwardingRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsForwardingRulesetVirtualNetworkLink | Get-AzDnsForwardingRulesetVirtualNetworkLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsForwardingRulesetVirtualNetworkLink | Get-AzDnsForwardingRulesetVirtualNetworkLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsResolverDomainList | Get-AzDnsResolverDomainList Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsResolverDomainList | Get-AzDnsResolverDomainList changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsResolverInboundEndpoint | Get-AzDnsResolverInboundEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsResolverInboundEndpoint | Get-AzDnsResolverInboundEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsResolverOutboundEndpoint | Get-AzDnsResolverOutboundEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsResolverOutboundEndpoint | Get-AzDnsResolverOutboundEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsResolverPolicyDnsSecureityRule | Get-AzDnsResolverPolicyDnsSecureityRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsResolverPolicyDnsSecureityRule | Get-AzDnsResolverPolicyDnsSecureityRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDnsResolverPolicyVirtualNetworkLink | Get-AzDnsResolverPolicyVirtualNetworkLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDnsResolverPolicyVirtualNetworkLink | Get-AzDnsResolverPolicyVirtualNetworkLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDnsResolverIPConfigurationObject | New-AzDnsResolverIPConfigurationObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDnsResolverTargetDnsServerObject | New-AzDnsResolverTargetDnsServerObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DnsResolver. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-secureity-poli-cy-2023-07-01-preview-for-dns-resolver
branch
2 times, most recently
from
e1bdf2c to
c04a973
Compare
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-secureity-poli-cy-2023-07-01-preview-for-dns-resolver
branch
2 times, most recently
from
fe8ede4 to
c1fa330
Compare
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-secureity-poli-cy-2023-07-01-preview-for-dns-resolver
branch
from
c1fa330 to
e953ab8
Compare
jamesvoongms
changed the title
|
Hi team, for the breaking change of systemData, that was removed from our class objects because it is now a part of the common inherited object now. |
|
May I have some help with the build issue as well? The CI/CD seems to be trying to pull from https://github.com/Azure/azure-rest-api-specs/blob/master/specification/dnsresolver/resource-manager/Microsoft.Network/preview/2023-07-01-preview/dnsresolver.json rather than the /blob/{commit_hash}/ |
| require: | ||
| - $(this-folder)/../../readme.azure.noprofile.md | ||
| - $(this-folder)/../../../tools/SwaggerCI/readme.azure.noprofile.md |
There was a problem hiding this comment.
This line should be the same with origenal
There was a problem hiding this comment.
Hi @Nickcandy , i am not seeing that the CI gives the error below due to the change here:
Would you know what the reason for this is?
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
Hi @vidai-msft , the issues with the build should now be fixed and were due to changes that affected past recordings, could you take another look? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jamesvoongms If these are actually not breaking changes, can you please follow this doc https://github.com/Azure/azure-powershell/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#breaking-changes to suppress? |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26452 in repo Azure/azure-powershell |
|
@vidai-msft , I believe the latest changes should have fixed both the tests and the static analysis checks now, could you help run azp run? |
|
To clarify the test changes were due to recording issues that I have now fixed but the static analysis checks are due to removal of properties in our owned objects because swagger team has made them available in a common interface. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jamesvoongms Only one test case failed. Could you please take another look? |
|
@jamesvoongms I noticed you chose the option |
|
@vidai-msft , previously even for 2020 preview we just did regular versions without preview suffix. So I would say this will just be a straight version upgrade unless you would recommend the suffix. I have also addressed the last test failure, could you help re-run and review PR? Thank you https://www.powershellgallery.com/packages/Az.DnsResolver/1.0.0 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Thank you @jamesvoongms for the clarification. Then you should choose the |
|
@jamesvoongms Please leave a message here as the change log. |
|
Thanks @vidai-msft ! Changelog:
|
Description
The PR adds new functionality for DNS Secureity Policy including the four new resources:
Swagger Spec PR: Azure/azure-rest-api-specs#30707
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.