Content-Length: 399107 | pFad | http://github.com/Azure/azure-rest-api-specs/pull/3149

D0 Reservations RP 2018-06-01 specs by juhee0202 · Pull Request #3149 · Azure/azure-rest-api-specs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reservations RP 2018-06-01 specs #3149

Merged
merged 6 commits into from
Jun 6, 2018
Merged

Reservations RP 2018-06-01 specs #3149

merged 6 commits into from
Jun 6, 2018

Conversation

juhee0202
Copy link
Contributor

@juhee0202 juhee0202 commented May 29, 2018 •
edited by azuresdkci
Loading

Link to private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/467

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from dsgouda May 29, 2018 23:06
@juhee0202
Copy link
Contributor Author

We are adding a new API version to Reservations API. We are planning to meet the following dates for SDK release. Please refer to the private PR which has been reviewed.

  • 2018-06-19 for CLI
  • 2018-06-15 for Powershell

@dsgouda
Copy link
Contributor

dsgouda commented May 29, 2018

Working on Network RP, reassigning

@AutorestCI AutorestCI mentioned this pull request May 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 29, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#228

@juhee0202 juhee0202 changed the title Reservations 2018-06-01 specs Reservations RP 2018-06-01 specs May 29, 2018
@AutorestCI
Copy link

AutorestCI commented May 29, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci azuresdkci assigned sergey-shandar and unassigned dsgouda May 29, 2018
@azuresdkci azuresdkci requested a review from sergey-shandar May 29, 2018 23:34
@AutorestCI
Copy link

AutorestCI commented May 30, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request May 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 30, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2695

@AutorestCI AutorestCI mentioned this pull request May 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented May 30, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1982

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 30, 2018
@lmazuel
Copy link
Member

lmazuel commented Jun 1, 2018

Hi @juhee0202
Since I already reviewed the PR I'm fine the content, it's pre-approved. Just a last question before merging, is this API public already in all regions where the previous API was? If not, could you give a timeline?
Thanks!

@juhee0202
Copy link
Contributor Author

Hi @lmazuel. The new API version is public but is only available to select users. It will be available for everyone on 6/18. Also, I would like to make one small renaming change before merging the PR. We added a new field called "autofit" in ReservationProperties object, but we would like to rename that. Currently pending on my team to decide the new property name.

@AutorestCI AutorestCI mentioned this pull request Jun 4, 2018
Merged
@juhee0202
Copy link
Contributor Author

@lmazuel just pushed the rename changes. please take another look!

@juhee0202
Copy link
Contributor Author

juhee0202 commented Jun 5, 2018 •
edited
Loading

Hi @lmazuel I have made changes from stable to preview for 2018-06-01. Please let me know if any other changes should be made before PR is merged.

@lmazuel lmazuel merged commit 2dd1182 into Azure:master Jun 6, 2018
@juhee0202 juhee0202 mentioned this pull request Jun 6, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@dsgouda dsgouda Awaiting requested review from dsgouda

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

Assignees

@lmazuel lmazuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juhee0202 @dsgouda @AutorestCI @lmazuel @sergey-shandar @azuresdkci








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/Azure/azure-rest-api-specs/pull/3149

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy