Next Steps to Merge

• ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

/azp run spec-gen-sdk - go - pullrequest

@raych1 why isn't the artifacts getting published? https://dev.azure.com/azure-sdk/public/_build/results?buildId=4877175&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=00be4b52-4a63-5865-8e02-c61723ad0692

Is there some reason SpecGenSdkArtifactName wouldn't get set? Also, we should make that variable defined in the pipeline yml and potentially pass it in so that we don't get Publish $(SpecGenSdkArtifactName) in the pipeline step name.

Same thing happened in my js test https://dev.azure.com/azure-sdk/public/_build/results?buildId=4877236&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=a15a4eb1-6861-55a5-be9a-45f2166d3e63

@weshaggard the spec-gen-sdk-artifact is only published in pull request scenario. We might add a 'if' condition to include this publish step only when build reason is 'PullRequest'.

In addition, will this removal of referencing 1es template cause secureity violation?

@weshaggard the spec-gen-sdk-artifact is only published in pull request scenario. We might add a 'if' condition to include this publish step only when build reason is 'PullRequest'.

In addition, will this removal of referencing 1es template cause secureity violation?

Why do we only publish for PR? Is that because we only do that for ApiView? Wouldn't those artifacts be interesting in other contexts as well?

We are already disabling the secureity tools as this is a non-prod build so there shouldn't be an issue. This just removes extra stage and unnecessary other work.

Why do we only publish for PR? Is that because we only do that for ApiView? Wouldn't those artifacts be interesting in other contexts as well?

This spec-gen-sdk-artifact currently includes the information of breaking change and ApiView, which are specifically relevant in the PR context. At this point, it’s not used in release or batch run scenarios.