Support reporting the duplicated SDK config issue in the batch run of spec-gen-sdk pipeline #34769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
weshaggard
approved these changes
May 21, 2025
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
spec-gen-sdk-runnertool, focusing on improving the handling of specification configurations, enhancing batch processing, and updating the underlying code structure. Key changes include the introduction of a newSpecConfigstype, the addition of a utility function to group specification paths, and updates to batch SDK generation logic to better manage configurations.Enhancements to Specification Configuration Handling:
SpecConfigsType: Added a newSpecConfigstype to represent pairedreadme.mdandtspconfig.yamlpaths, improving clarity and reducing ambiguity in spec configuration handling (eng/tools/spec-gen-sdk-runner/src/utils.ts).groupSpecConfigPathsfunction to groupreadme.mdandtspconfig.yamlfiles by service, enabling more structured processing of specs (eng/tools/spec-gen-sdk-runner/src/spec-helpers.ts).Improvements to Batch SDK Generation:
getSpecPaths: Updated thegetSpecPathsfunction to return an array ofSpecConfigs, replacing the previous flat string array approach. This change supports more complex batch run scenarios (eng/tools/spec-gen-sdk-runner/src/command-helpers.ts).eng/tools/spec-gen-sdk-runner/src/commands.ts). [1] [2]Code Structure and Test Updates:
change-files.tstospec-helpers.tsand moved relevant functions for better organization (eng/tools/spec-gen-sdk-runner/src/spec-helpers.ts).eng/tools/spec-gen-sdk-runner/test/src/__snapshots__/commands.test.ts.snap).This is a test run