[Storage] [DataMovement] NFS over REST Azure SDK Feedback #50369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickliu-msft
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft and
jalauzon-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the RawProperties setter in StorageResourceContainerProperties and replaces it with a constructor-based injection, updating all call sites and generated API signatures accordingly.
- Introduce a new constructor on
StorageResourceContainerPropertiesto acceptRawPropertiesand remove its setter - Update extension methods and generated API files to use the new constructor overload
- Adjust doc comments, default initializations, and the CHANGELOG to reflect the changes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/Azure.Storage.DataMovement/src/StorageResourceContainerProperties.cs | Removed setter from RawProperties, added constructor injection |
| sdk/storage/Azure.Storage.DataMovement/src/Shared/DataMovementExtensions.cs | Deleted obsolete ToStorageResourceContainerProperties helper |
| sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.netstandard2.0.cs | Updated API surface: removed setter and added constructor overload |
| sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.net8.0.cs | Updated API surface similarly |
| sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.net6.0.cs | Updated API surface similarly |
| sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/SharesPathScanner.cs | Changed destinationPermissionKey initialization to default |
| sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/ShareFileStorageResourceOptions.cs | Refined protocol validation doc comment |
| sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs | Updated call sites to use new StorageResourceContainerProperties constructor |
| sdk/storage/Azure.Storage.DataMovement.Files.Shares/CHANGELOG.md | Added notes for NFS/SMB support and protocol validation |
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/SharesPathScanner.cs
Show resolved
Hide resolved
nickliu-msft
commented
Jun 2, 2025
sdk/storage/Azure.Storage.DataMovement/src/StorageResourceContainerProperties.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
nickliu-msft
commented
Jun 3, 2025
sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.net6.0.cs
Outdated
Show resolved
Hide resolved
…ovement.net6.0.cs
amnguye
approved these changes
Jun 3, 2025
sdk/storage/Azure.Storage.DataMovement.Files.Shares/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/CHANGELOG.md
Outdated
Show resolved
Hide resolved
amnguye
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one feedback left by Krzysztof is to remove the setter from StorageResourceContainerProperties.RawProperties
https://spa.apiview.dev/review/fffb907bd4224ac4b0f95dfb164a72e3?activeApiRevisionId=97d6fe72071647778dc8ebf8ec528145&diffApiRevisionId=178e9f025cc64925894a5f5326c1922e&diffStyle=trees