Type forward system events #50371
Merged
Type forward system events #50371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A set of customization model additions and updates for Event Grid system events, primarily introducing new partial classes, properties, and adjusting codegen attributes.
- Convert a factory class into a partial model class for API Management token expiry.
- Add custom properties (e.g.,
Rules,Properties,LabelValue,TimeToLive) to various event data types. - Update namespace qualifiers for consistency and add a constants file for media events.
Reviewed Changes
Copilot reviewed 1077 out of 1077 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/ApiManagementGatewayTokenNearExpiryProperties.cs | Replace factory class with a partial model and update CodeGenModel attribute. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/ApiManagementCircuitBreakerProperties.cs | Add ApiManagementCircuitBreakerProperties class with a Rules dictionary. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsRouterWorkerSelector.cs | Reintroduce TtlSeconds, TimeToLive, and add LabelValue property. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsRouterJobReceivedEventData.cs | Remove fully qualified Azure.Messaging.EventGrid.Models prefix in favor of Models. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadPropertiesUpdatedPerUserEventData.cs | Add Properties dictionary to event data. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadPropertiesUpdatedEventData.cs | Add Properties dictionary to event data. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadCreatedWithUserEventData.cs | Add Properties dictionary to event data. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadCreatedEventData.cs | Add Properties dictionary to event data. |
| sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Constants.cs | Introduce Constants.MediaEvents.NotApplicable. |
Comments suppressed due to low confidence (6)
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/ApiManagementCircuitBreakerProperties.cs:11
- The
Rulesproperty is declared as get-only with no backing field or constructor initialization, so it will always be null. Consider adding a constructor parameter or initializer to set this property.
public IReadOnlyDictionary<string, object> Rules { get; }
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsRouterJobReceivedEventData.cs:17
- The
Modelsnamespace alias is not imported, so this qualifier may not resolve. Add ausing Azure.Messaging.EventGrid.Models;directive or use the fully qualified namespace.
public Models.AcsRouterJobStatus? JobStatus
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadPropertiesUpdatedPerUserEventData.cs:14
- The
Propertiesproperty is get-only with no initialization or constructor assignment and will always be null. Consider providing a constructor or initializer to populate this dictionary.
public IReadOnlyDictionary<string, object> Properties { get; }
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadPropertiesUpdatedEventData.cs:14
- The
Propertiesproperty is get-only with no initialization or constructor assignment and will always be null. Consider providing a constructor or initializer to populate this dictionary.
public IReadOnlyDictionary<string, object> Properties { get; }
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadCreatedWithUserEventData.cs:14
- The
Propertiesproperty is get-only with no initialization or constructor assignment and will always be null. Consider providing a constructor or initializer to populate this dictionary.
public IReadOnlyDictionary<string, object> Properties { get; }
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/AcsChatThreadCreatedEventData.cs:14
- The
Propertiesproperty is get-only with no initialization or constructor assignment and will always be null. Consider providing a constructor or initializer to populate this dictionary.
public IReadOnlyDictionary<string, object> Properties { get; }
JoshLove-msft
commented
Jun 3, 2025
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/tsp-location.yaml
Outdated
Show resolved
Hide resolved
jsquire
approved these changes
Jun 3, 2025
jsquire
approved these changes
Jun 3, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews Azure.Messaging.EventGrid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.