Removing deprecating SQL versions and Sql Server Communication Links #50384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfrosti
requested review from
ArthurMa1978,
m-nash and
ArcturusZhang
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated SQL Server versions (2014 releases) and eliminates the SqlServerCommunicationLink class.
- Removed V2014_01_01 and V2014_04_01 from ResourceVersions in multiple SQL resource classes.
- Removed the SqlServerCommunicationLink class from the netstandard2.0 API.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/provisioning/Azure.Provisioning.Sql/api/Azure.Provisioning.Sql.netstandard2.0.cs | Removed deprecated version strings and the obsolete SqlServerCommunicationLink class. |
| sdk/provisioning/Azure.Provisioning.Sql/api/Azure.Provisioning.Sql.net8.0.cs | Removed deprecated version strings from ResourceVersions. |
Comments suppressed due to low confidence (3)
sdk/provisioning/Azure.Provisioning.Sql/api/Azure.Provisioning.Sql.netstandard2.0.cs:121
- Ensure that the removal of deprecated SQL Server versions from the ResourceVersions is reflected in related documentation and migration guides.
public static readonly string V2014_01_01;
sdk/provisioning/Azure.Provisioning.Sql/api/Azure.Provisioning.Sql.netstandard2.0.cs:1914
- The removal of the SqlServerCommunicationLink class appears intentional; please verify that all client references and associated documentation are updated accordingly.
public partial class SqlServerCommunicationLink : Azure.Provisioning.Primitives.ProvisionableResource
sdk/provisioning/Azure.Provisioning.Sql/api/Azure.Provisioning.Sql.net8.0.cs:121
- Confirm that the removal of the deprecated SQL Server versions in the ResourceVersions is documented and that tests are updated to reflect these changes.
public static readonly string V2014_01_01;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecating SQL versions and Sql Server Communication Links
2014 versions.