Prepare for release #50401
Merged
Prepare for release #50401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
christothes,
KrzysztofCwalina,
tg-msft,
jsquire,
m-nash,
ArthurMa1978,
jorgerangel-msft and
m-redding
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the EventGrid SDK for release by switching to the published SystemEvents package and updating its version centrally.
- Switches the SystemEvents reference in the EventGrid project from a local project to a NuGet package.
- Adds a central version update for
Azure.Messaging.EventGrid.SystemEventsin the shared props.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/eventgrid/Azure.Messaging.EventGrid/src/Azure.Messaging.EventGrid.csproj | Added <PackageReference> for SystemEvents and removed the local project reference |
| eng/Packages.Data.props | Added <PackageReference Update> entry for SystemEvents version 1.0.0-beta.4 |
Comments suppressed due to low confidence (1)
eng/Packages.Data.props:122
- Adding this new package dependency may introduce new behaviors; consider adding or updating tests to cover any scenarios involving the SystemEvents integration.
<PackageReference Update="Azure.Messaging.EventGrid.SystemEvents" Version="1.0.0-beta.4" />
sdk/eventgrid/Azure.Messaging.EventGrid/src/Azure.Messaging.EventGrid.csproj
Show resolved
Hide resolved
jsquire
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.