Content-Length: 375983 | pFad | http://github.com/Azure/azure-sdk-for-net/pull/50442

6D Health migration by JoshLove-msft · Pull Request #50442 · Azure/azure-sdk-for-net · GitHub
Skip to content

Health migration #50442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Health migration #50442

wants to merge 15 commits into from

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Jun 5, 2025 •
edited
Loading

Fixes #47254

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.Health.Deidentification

@JoshLove-msft JoshLove-msft marked this pull request as ready for review June 6, 2025 23:35
@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 23:35
@JoshLove-msft JoshLove-msft requested review from alexathomases and a team as code owners June 6, 2025 23:35
Copilot
Copilot AI reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements changes for the "Health migration" by addressing issue #47254. Key updates include updating the specification YAML file (commit change and new emitterPackageJsonPath), renaming internal client methods in the DeidentificationClient, and adding new overloads and virtual methods (for JSON and persistable model creation) across the API surface.

Reviewed Changes

Copilot reviewed 71 out of 71 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/healthdataaiservices/Azure.Health.Deidentification/tsp-location.yaml Updated commit reference and added emitterPackageJsonPath to support emitter configuration.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/PhiTaggerResult.cs Introduced a new partial class exposing a read-only Entities list.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/PhiEntity.cs Added a new partial class as a placeholder for PhiEntity functionality.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/HealthDeidentificationModelFactory.cs Added model factory methods and attributes to support code generation.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/HealthDeidentificationClientBuilderExtensions.cs Added an extensions class for client builder functionality.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/DeidentificationClient.cs Renamed internal methods (from GetJobsInternals to ListJobsInternal) and updated client calls accordingly.
sdk/healthdataaiservices/Azure.Health.Deidentification/src/Azure.Health.Deidentification.csproj Added a new property to disable AutoRest dependency.
sdk/healthdataaiservices/Azure.Health.Deidentification/api/Azure.Health.Deidentification.netstandard2.0.cs Updated DeleteJob overloads and added new virtual methods for JSON/persistable model handling.
sdk/healthdataaiservices/Azure.Health.Deidentification/api/Azure.Health.Deidentification.net8.0.cs Similar API updates as netstandard2.0 with revised DeleteJob overloads and additional JSON model methods.
Comments suppressed due to low confidence (2)

sdk/healthdataaiservices/Azure.Health.Deidentification/api/Azure.Health.Deidentification.netstandard2.0.cs:27

  • Removing the default value for the Azure.RequestContext parameter in the DeleteJob method may affect backward compatibility; please confirm that this change is intentional and that documentation is updated accordingly.
public virtual Azure.Response DeleteJob(string jobName, Azure.RequestContext context) { throw null; }

sdk/healthdataaiservices/Azure.Health.Deidentification/src/DeidentificationClient.cs:25

  • [nitpick] The renaming from GetJobsInternalsAsync to ListJobsInternalAsync enhances clarity; please ensure that related documentation and internal tests are updated to reflect this change.
return ListJobsInternalAsync(maxpagesize, null, cancellationToken);

@JoshLove-msft JoshLove-msft mentioned this pull request Jun 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@alexathomases alexathomases alexathomases approved these changes

@jorgerangel-msft jorgerangel-msft jorgerangel-msft approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Health Deidentification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure Plugin] Generate Azure.Health.Deidentification
3 participants
@JoshLove-msft @alexathomases @jorgerangel-msft








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/Azure/azure-sdk-for-net/pull/50442

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy