Adopt special-headers and serialization spector scenarios #50471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
m-nash,
jorgerangel-msft,
live1206,
ArcturusZhang and
jsquire
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adopts new Spector scenarios for special headers and serialization, addressing the issue #48064 by adding new tests for special header behaviors and JSON property encoding.
- Added tests for repeatability and conditional request headers.
- Added tests for JSON-encoded name serialization.
- Updated the test projects’ csproj by removing the Azure.Core package reference to better align dependencies.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/SpecialHeaders/Repeatability/RepeatabilityTests.cs | Introduces tests for repeatability headers, verifying header values and ensuring no unintended parameters. |
| eng/packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/SpecialHeaders/ConditionalRequest/ConditionalRequestHeaderTests.cs | Adds tests for conditional request headers with various HTTP methods and header scenarios. |
| eng/packages/http-client-csharp/generator/TestProjects/Spector.Tests/Http/Serialization/EncodedName/Json/EncodedNameJsonTests.cs | Implements tests for JSON serialization using encoded property names. |
| eng/packages/http-client-csharp/generator/TestProjects/Local.Tests/TestProjects.Local.Tests.csproj | Removes the Azure.Core package reference to reflect updated dependency requirements. |
github-actions
bot
added
Client
jorgerangel-msft
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48064