[http-client-csharp-mgmt] Generate tag related methods #50482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyuazhang
requested review from
JoshLove-msft,
m-nash,
jorgerangel-msft,
live1206 and
ArcturusZhang
as code owners
github-actions
bot
added
CodeGen
There was a problem hiding this comment.
Pull Request Overview
This PR adds new tag-related methods to the HTTP client management generator, enabling add, remove (and potentially set) operations on resource tags while refactoring diagnostic and pipeline processing statements. Key changes include:
- Introduction of new tag method providers (AddTagMethodProvider, RemoveTagMethodProvider, and a placeholder for SetTagsMethodProvider).
- Enhancements to diagnostic scope and pipeline processing by leveraging shared snippet helpers.
- Updates to the ResourceClientProvider to include tag providers and improve argument population.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ResourceMethodSnippets.cs | Added diagnostic scope helper methods for resource operations. |
| SetTagsMethodProvider.cs | Implemented tag-setting provider with conditional logic for tag resource usage. |
| RemoveTagMethodProvider.cs | Implemented tag removal provider with primary and secondary execution paths. |
| BaseTagMethodProvider.cs | Provided common functionality shared by tag method providers. |
| AddTagMethodProvider.cs | Implemented tag addition provider supporting both sync and async scenarios. |
| ResourceClientProvider.cs | Updated to register tag method providers and improved argument population. |
| ResourceOperationMethodProvider.cs | Refactored pipeline processing to use shared diagnostic snippet methods. |
| KnownAzureParameters.cs | Updated cancellation token parameter with a default value. |
Comments suppressed due to low confidence (1)
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/TagMethodProviders/RemoveTagMethodProvider.cs:128
- Ensure that the reference to 'WaitUntil' is consistently qualified across providers (e.g., use 'Azure.WaitUntil' if that is the convention used in other tag method providers).
Static(typeof(WaitUntil)).Property("Completed"),
...ent-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ResourceClientProvider.cs
Show resolved
Hide resolved
live1206
reviewed
Jun 9, 2025
...ient-csharp-mgmt/generator/Azure.Generator.Management/src/Primitives/KnownAzureParameters.cs
Outdated
Show resolved
Hide resolved
...nerator.Management/src/Providers/OperationMethodProviders/ResourceOperationMethodProvider.cs
Outdated
Show resolved
Hide resolved
...nerator.Management/src/Providers/OperationMethodProviders/ResourceOperationMethodProvider.cs
Outdated
Show resolved
Hide resolved
...ient-csharp-mgmt/generator/Azure.Generator.Management/src/Snippets/ResourceMethodSnippets.cs
Outdated
Show resolved
Hide resolved
...ient-csharp-mgmt/generator/Azure.Generator.Management/src/Snippets/ResourceMethodSnippets.cs
Show resolved
Hide resolved
...nerator.Management/src/Providers/OperationMethodProviders/ResourceOperationMethodProvider.cs
Show resolved
Hide resolved
live1206
reviewed
Jun 9, 2025
...nerator/Azure.Generator.Management/src/Providers/TagMethodProviders/BaseTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...nerator/Azure.Generator.Management/src/Providers/TagMethodProviders/BaseTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...enerator/Azure.Generator.Management/src/Providers/TagMethodProviders/AddTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...enerator/Azure.Generator.Management/src/Providers/TagMethodProviders/AddTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...enerator/Azure.Generator.Management/src/Providers/TagMethodProviders/AddTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...nerator/Azure.Generator.Management/src/Providers/TagMethodProviders/BaseTagMethodProvider.cs
Outdated
Show resolved
Hide resolved
...nerator/Azure.Generator.Management/src/Providers/TagMethodProviders/BaseTagMethodProvider.cs
Show resolved
Hide resolved
|
And also, can we have some UT to verify the generated methods? |
Unit tests added. |
live1206
reviewed
Jun 10, 2025
...nt-csharp-mgmt/generator/Azure.Generator.Management/test/Providers/TagMethodProviderTests.cs
Outdated
Show resolved
Hide resolved
...nt-csharp-mgmt/generator/Azure.Generator.Management/test/Providers/TagMethodProviderTests.cs
Outdated
Show resolved
Hide resolved
live1206
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate tag related methods in Resource.