Refactor managed identity as FIC implementation in extensions lib #50501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors the managed identity federated identity credential implementation to use the new ManagedIdentityId.From helpers, updates configuration keys and exception messaging in the client factory, and corrects the changelog’s documentation link.
- Simplify
ManagedFederatedIdentityCredentialby consolidating constructors and usingManagedIdentityId. - Update
ClientFactoryto useManagedIdentityId.From*methods and adjust the error message parameter names. - Fix the changelog link to point directly at the revised docs section.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ManagedFederatedIdentityCredential.cs | Removed overloads and switch, now uses single constructor with ManagedIdentityId. |
| sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ClientFactory.cs | Updated exception text and switched calls to ManagedIdentityId.FromUserAssigned*. |
| sdk/extensions/Microsoft.Extensions.Azure/CHANGELOG.md | Updated feature link to the correct anchors in the Microsoft docs. |
Comments suppressed due to low confidence (2)
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ClientFactory.cs:200
- The
objectIdbranch still passes the rawobjectIdstring instead of usingManagedIdentityId.FromUserAssignedObjectId. Update this to useManagedIdentityId.FromUserAssignedObjectId(objectId)for consistency with the other branches.
return new ManagedFederatedIdentityCredential(tenantId, clientId, objectId, azureCloud, additionallyAllowedTenantsList);
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ManagedFederatedIdentityCredential.cs:68
- Consider adding unit tests to verify that the simplified constructor correctly handles each
ManagedIdentityIdvariant (client ID, resource ID, object ID) and yields the expectedManagedIdentityCredential.
_managedIdentityCredential = new ManagedIdentityCredential(managedIdentityId);
jsquire
reviewed
Jun 9, 2025
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ClientFactory.cs
Outdated
Show resolved
Hide resolved
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ManagedFederatedIdentityCredential.cs
Show resolved
Hide resolved
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/ManagedFederatedIdentityCredential.cs
Show resolved
Hide resolved
jsquire
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ManagedIdentityId.Fromhelper methods, which allows us to simplify theManagedFederatedIdentityCredentialclass