Add the demonstration of include parameter. #50506
Open
+274
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o nirovins/add_sample_for_include
nick863
requested review from
trangevi,
dargilco,
jhakulin and
glharper
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds demonstration code for the include parameter in run steps while updating sample documentation and cleaning up tests.
- Introduces asynchronous and synchronous snippets for obtaining run step details with the include parameter
- Removes an ignored test in the persistent agents tests
- Updates sample documentation and asset tag metadata
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/ai/Azure.AI.Agents.Persistent/tests/Samples/Sample_PersistentAgents_FileSearch.cs | Adds new snippet regions illustrating the include parameter usage in asynchronous and synchronous flows |
| sdk/ai/Azure.AI.Agents.Persistent/tests/PersistentAgentsTests.cs | Removes an ignored test comment related to service regression |
| sdk/ai/Azure.AI.Agents.Persistent/samples/Sample6_PersistentAgents_FileSearch.md | Updates sample narratives and code snippets to align with the new demonstration |
| sdk/ai/Azure.AI.Agents.Persistent/assets.json | Updates asset tag value |
Comments suppressed due to low confidence (3)
sdk/ai/Azure.AI.Agents.Persistent/tests/Samples/Sample_PersistentAgents_FileSearch.cs:103
- The variable name 'fileSearh' appears to be a typo. Consider renaming it to 'fileSearch' for clarity and consistency.
if (toolCall is RunStepFileSearchToolCall fileSearh)
sdk/ai/Azure.AI.Agents.Persistent/tests/Samples/Sample_PersistentAgents_FileSearch.cs:212
- The typo in the variable name 'fileSearh' should be corrected to 'fileSearch' to avoid confusion in the code.
if (toolCall is RunStepFileSearchToolCall fileSearh)
sdk/ai/Azure.AI.Agents.Persistent/samples/Sample6_PersistentAgents_FileSearch.md:214
- There is a typo in the sample code variable name 'fileSearh'; it is recommended to change it to 'fileSearch' for consistency.
if (toolCall is RunStepFileSearchToolCall fileSearh)
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
nick863
force-pushed
the
nirovins/add_sample_for_include
branch
from
8cf6cb7 to
95b8449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.