feat: add support for konnectID CP references #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/support-konnectid-cp-refs
branch
7 times, most recently
from
a4f4ec3 to
cba5094
Compare
czeslavo
changed the title
czeslavo
force-pushed
the
feat/support-konnectid-cp-refs
branch
2 times, most recently
from
d6fa205 to
40705e6
Compare
pmalek
previously approved these changes
Jan 16, 2025
1 task
czeslavo
force-pushed
the
feat/support-konnectid-cp-refs
branch
2 times, most recently
from
f15b7c9 to
543aef2
Compare
czeslavo
force-pushed
the
feat/support-konnectid-cp-refs
branch
from
543aef2 to
c6f1739
Compare
|
@pmalek |
pmalek
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds support for
type=konnectIDcontrol plane references for all Konnect entities that can refer to a CP.Which issue this PR fixes
Closes #922.
Special notes for your reviewer:
It's over 1k lines of changes, but mostly these are mundane alignments that had to be done for all types at once.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes