Content-Length: 340009 | pFad | http://github.com/NativeScript/NativeScript/pull/10455/files

7F fix(core): safe important check by wSedlacek · Pull Request #10455 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): safe important check #10455

Merged
merged 7 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/apps_automated.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20.10.0

- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Install Python
uses: actions/setup-python@v4
Expand All @@ -49,6 +49,8 @@ jobs:

- name: Create Emulator
uses: rigor789/action-create-emulator@main
with:
package: system-images;android-34;default;x86_64

- name: Test (Android)
run: node tools/scripts/run-automated.js android
Expand Down
6 changes: 5 additions & 1 deletion packages/core/ui/styling/css-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import { Trace } from '../../trace';
import { CoreTypes } from '../../core-types';
import { Length } from './style-properties';

export function cleanupImportantFlags(value: string, propertyName: string) {
export function cleanupImportantFlags(value: unknown, propertyName: string) {
if (typeof value !== 'string') {
return '' + value;
}

const index = value?.indexOf('!important');
if (index >= 0) {
if (Trace.isEnabled()) {
Expand Down
2 changes: 1 addition & 1 deletion tools/scripts/run-automated.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const spawn = require('child_process').spawn
const kill = require('tree-kill');
const path = require('path');

const TIMEOUT_MS = 5 * 60 * 1000; // 5 minutes
const TIMEOUT_MS = 20 * 60 * 1000; // 20 minutes (is Github CI this slow to boot AVDs?)
const workspaceDir = path.resolve(__dirname, '../..');
const platform = process.argv[2];
const spawned_process = spawn(
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/NativeScript/NativeScript/pull/10455/files

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy