fix(core): Provided image source gets unintentionally disposed #10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Image provided source has its native instance disposed during view disposal even when
ImageSourceinstance is provided by developer.What is the new behavior?
Image provided source does not have its native instance disposed during view disposal when
ImageSourceinstance is provided by developer.To avoid this, we wrap the native source inside a new
ImageSourceinstance.Developers will be responsible for cleaning up the image sources they provide just like it has always been for android.
Also, improved code readability for
ImageSource.setNativeSource.Fixes #9820 (revisited) #10625