text-transform and text-decoration with formattedText fixed #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchev
force-pushed
the
text-transform-fix
branch
from
586be7b to
d7b1329
Compare
| } else { | ||
| setTextDecorationNative(view, view.text || view.attributedText, NSMutableDictionary.alloc().init()); | ||
| let source = v.text; | ||
| let attributes = NSMutableArray.array(); |
There was a problem hiding this comment.
According to ios-runtime it will be much faster if we pass JS array here.
|
👍 but it would be better if we switch NSArray & NSDictionary to JS Array and JS Map. |
|
run ci |
enchev
pushed a commit
that referenced
this pull request
Jan 12, 2016
text-transform and text-decoration with formattedText fixed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1280