feat: Add support for 'projectName' setting (#2107) #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Adrian Burgess.
|
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Linked to PRs NativeScript/NativeScript#10550 and NativeScript/docs#143. |
5 tasks
5 tasks
NathanWalker
approved these changes
May 24, 2024
NathanWalker
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently the files generated during the build process take the project name from the basename of the directory the project is contained in.
What is the new behavior?
If (and only if) the new 'projectName' setting is present in the nativescript.config.ts file, the name specified there is used instead of the basename of the project directory.
Fixes/Implements/Closes #2107
(Note on iOS this requires an additional patch to @nativescript/webpack5 that will be linked below)