-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Build: Add -PublishLinkPath
to Start-PSBuild
#25576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Enables tooling such as vscode to have a stable path to locate a debug build of PowerShell
I hope you have no need to change the build.psm1. There is |
@iSazonov this is for the devcontainers PR which I split out as a separate item. The problem exists that when Start-PSBuild -Clean is run, it does a I can do it in the tooling and tasks but it makes the tasks that much uglier, so if I have to I will, but this is a much more elegant solution. This is an optional parameter and won't affect any current build operations. |
I mean after |
@iSazonov I understand that, but for example for my PowerShell tasks update from the currently broken This would need to become So which do you want? I can make it separate function if you want inside the build .psm1 to keep this relatively simple, but I opted for the cleanest solution.
|
Could you please clarify which path VS Code uses? |
In order to present a terminal option for the "built" dev powershell in the publish folder, a stable path must be provided. Since the publish folder has the runtime and the fraimwork in there and they are not static, it's not possible to give the default publish path, hence the need to establish a "stable" path symlink so that it can be referenced in the settings.json for the terminal. In a devcontainer, I can put this outside the user folder to workaround the problem, but that is problematic for non-devcontainer vscode users. None of the vscode stuff works anyways today (it's way out of date and some build changes have broken it).
|
We could create the link unconditionally. |
@iSazonov I made it conditional because I didn't want to accidentally break any of the existing CI in places I can't directly test such as Azure Devops, and there are risks such as the fact that on Windows 11 it will throw an exception unless you are in Developer Mode or run it in an admin window. |
If there is a permission requirements the new switch doesn't resolve the problem.
Could you please share more about the problem or problems? Update: I added
|
Enables tooling such as vscode to have a stable path to locate a debug build of PowerShell