Content-Length: 259137 | pFad | http://github.com/adafruit/circuitpython/pull/10185

B3 mp3 samples are signed by jepler · Pull Request #10185 · adafruit/circuitpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3 samples are signed #10185

Merged
merged 2 commits into from
Mar 26, 2025
Merged

mp3 samples are signed #10185

merged 2 commits into from
Mar 26, 2025

Conversation

jepler
Copy link

@jepler jepler commented Mar 26, 2025

Closes: #10175

@jepler jepler changed the base branch from main to 9.2.x March 26, 2025 14:26
@jepler jepler requested a review from dhalbert March 26, 2025 14:27
This test was written in such a way that having a wrong data type
for the mp3 samples wasn't detected. Instead of using
np.frombuffer(dtype=int16), just do arithmetic directly on the
samples. During testing time we don't care if it might be a little
slower or use a little more RAM than ulab, and we don't care
whether it's actually an RMS calculation.  Just that it's
consistent and shows the audio data is correct, including its
defined data type.
@jepler
Copy link
Author

jepler commented Mar 26, 2025

The improved "issue9705" test would have detected this regression.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!

@dhalbert dhalbert merged commit 81d96ac into adafruit:9.2.x Mar 26, 2025
485 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distorted mp3 playback on MAX98357A
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/adafruit/circuitpython/pull/10185

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy