Fix analogbufio.BufferedIn pin validation on RP2350B #10202
Merged
+24
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightycc
previously approved these changes
Mar 30, 2025
dhalbert
force-pushed
the
analogbufio-pin-validation
branch
from
9c0fe60 to
aa580ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Adafruit Metro RP2350 analogbufio #10201.
Fix
analogbufio.BufferedInpin validation on RP2350B.Use
pico-sdk-suppliedADC_BASE_PINinstead of figuring out the base pin ourselves.Disallow using
board.A3(GPIO29) on Pico W and Pico 2 W foranalogbufio.BufferedIn, and document that. GPIO29 pin has a voltage divider attached to monitor VSYS, and is also shared with SPI SCK connected to the radio module.AnalogInspecial-casesA3to make it available, but that was complicated, and I think the use case for GPIO29 withanalogbufiois limited.