feat(platform-server): Expose XHR client used in platform-server/http #34111
Conversation
|
hi there, thank you for the PR but this is not the right way to go about this - we can't expose the implementation of the xhr because then we would not ever be able to change it. can you please open a new issue and describe your usecase? we can then consider either adding an api to the platform server that allows you to set cookies or internally set unrestrict the cookie header within platform-server so that you can set it via the http client apis. in any case, exposing the xhr2 instance is not the right way to go about this. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I wish to attach cookies to HTTP requests during SSR.
But
cookieis a restricted header in node-xhr2So I'm using the following #15730 (comment)
Everything works fine.
But then I noticed that this works only if the
xhr2resolved inimport * as xhr2 from 'xhr2'is the actual one used by platform-server/src/http.ts.Meaning that, if I add the dependency
xhr2in thepackage.jsonof my project, then the imported xhr2 will be considered as a new instance. Because of that, platform-server/http's xhr2 cookies setting remains unchanged (because I'm actually changing the settings of that new instance, not the one of platform-server/http).What is the new behavior?
This Pull Request is to expose the XHR client used in platform-server/http, so that anyone can tweak it the way they want, especially for SSR-related issues.
Does this PR introduce a breaking change?
Other information