refactor(core): reduce navigator.userAgent checks size
#60728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
requires: TGP
In this commit, we move `navigator.userAgent` into a variable and reuse it in multiple places. This implementation is 100+ bytes shorter than repeatedly checking `typeof navigator`.
arturovt
force-pushed
the
refactor/core-user-agent-check
branch
from
8ff7459 to
d553c94
Compare
diicar
reviewed
Apr 3, 2025
| export const isIe: boolean = | ||
| typeof navigator !== 'undefined' && | ||
| (/MSIE/.test(navigator.userAgent) || /Trident/.test(navigator.userAgent)); | ||
| export const isIe = /MSIE/.test(userAgent) || /Trident/.test(userAgent); |
There was a problem hiding this comment.
As IE no longer supported, why not to remove it ?
There was a problem hiding this comment.
Primitives are used in Google outside of angular apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we move
navigator.userAgentinto a variable and reuse it in multiple places. This implementation is 100+ bytes shorter than repeatedly checkingtypeof navigator.