Content-Length: 295186 | pFad | http://github.com/angular/angular/pull/60738

9D docs(docs-infra): first-app tutorial - minor corrections by ryncdr · Pull Request #60738 · angular/angular · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): first-app tutorial - minor corrections #60738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryncdr
Copy link

@ryncdr ryncdr commented Apr 4, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The tutorial as written does not properly fetch data after updating Housing Service to fetch from a JSON server.
const data = await fetch(`${this.url}/${id}`);
Issue Number: N/A

What is the new behavior?

The fetch method now properly queries the DB by the id property specified in the route.
const data = await fetch(`${this.url}?id=${id}`);

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ryncdr added 2 commits April 4, 2025 00:45
Updated housing.service.ts > getHousingLocationById()
 - Added search parameter to fetch URL
 - Returns single object instead of array
Added HELPFUL note calling attention to subtle change made in prior code (commit 7e05f8c).
Copy link

google-cla bot commented Apr 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from MarkTechson April 4, 2025 04:49
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Apr 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 4, 2025
Copy link

github-actions bot commented Apr 4, 2025

Deployed adev-preview for 6dd2b26 to: https://ng-dev-previews-fw--pr-angular-angular-60738-adev-prev-rqa1rlh9.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
Copy link
Member

Hi,

Could you please fix the formatting (cf the linting issue on adev/src/content/tutorials/first-app/steps/14-http/src-final/app/housing.service.ts) and squash both commits. Thank you

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/60738

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy