refactor(devtools): create highlight overlay on node selection #60744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, highlighting works only when a directive explorer node is hovered. The change enables this feature on node selection as well.
JeanMeche
reviewed
Apr 4, 2025
| @@ -57,12 +57,16 @@ import {serializeDirectiveState} from './state-serializer/state-serializer'; | |||
| import {runOutsideAngular, unwrapSignal} from './utils'; | |||
| import {DirectiveForestHooks} from './hooks/hooks'; | |||
|
|
|||
| type InspectorRef = {ref: ComponentInspector | null}; | |||
There was a problem hiding this comment.
Any specfic reason for introducing this type instead of using ComponentInspector | null directly ?
There was a problem hiding this comment.
Mainly for emphasizing and making it clear what's the role of this object. I added the type after the fact.
Edit: Also, the type is used in 2 places so it prevents minor repetition.
hawkgs
commented
Apr 4, 2025
devtools/projects/ng-devtools-backend/src/lib/client-event-subscribers.ts
Show resolved
Hide resolved
dgp1130
approved these changes
Apr 4, 2025
AleksanderBodurri
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Component highlighting works only when you hover a directive explorer node which is okay when you click on it but doesn't work when you use the keyboard to navigate through the tree.
What is the new behavior?
The change enables this feature on node selection as well.
cc @dgp1130
Screen.Recording.2025-04-04.at.13.23.18.mov
Does this PR introduce a breaking change?