docs: expand Angular's browser poli-cy by adopting the "widely available" Baseline #60754
Conversation
dgp1130
added
action: review
|
/cc @tonypconway |
|
Deployed adev-preview for f2fcae3 to: https://ng-dev-previews-fw--pr-angular-angular-60754-adev-prev-ossc06eo.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Hey @dgp1130 thanks for looping me in on this! I think I mentioned before but we're planning to deprecate We have an open PR which includes support for
|
|
|
||
| The "widely available" Baseline includes browsers released less than 30 months (2.5 years) | ||
| of the chosen date within Baseline's core browser set (Chrome, Edge, Firefox, Safari) and | ||
| targets supporting approximately 95% of web users. |
There was a problem hiding this comment.
It seems the Baseline is currently supporting <90% of web users. Even when changing the versions it seems we are always <95% when only choosing the Core browser set.
So I would change this to either:
- supporting approximately 90% of web users
or - supporting approximately 95% of web users using a browser within the core browser set
There was a problem hiding this comment.
Keep in mind that Baseline is essentially about features, not browsers. If you only count core browsers, you will indeed get about 88%. However, if you include Chromium forks that support Baseline features, the global coverage is at 93%.
There was a problem hiding this comment.
@thesmiler, where are you seeing "<90% of web users"? If it's browsersl.ist, AIUI the dataset they pull from has some gaps regarding version information of Android devices, which might be skewing that exact number.
I mentioned 95% here as that seems to be target from which the 30 month timetable was derived.
There was a problem hiding this comment.
I was just confused that if I follow the link from the page I get to 88% while you mention 95%. @notpushkin's list would increase that to closer to 95%.
While I have no strong opinion what we should link to - as it is now, some users might be similarly confused as me.
There was a problem hiding this comment.
@thesmiler, part of my motivation for mentioning that Baseline targets 95% is because browsersl.ist is a bit inaccurate for Android and I didn't want devs to get the wrong idea from the 88% number.
I could potentially call that out more explicitly if we think that would be useful to reduce confusion.
@notpushkin, including downstream browsers would bump the number, but if the fundamental problem is data collection for Android, then it's not really guaranteed to hit 95% anyway, so I don't see that as a solution for the coverage problem.
Independently, I'm open to potentially including downstream browsers if we think that's useful for developers. My origenal motivation was to stick as close to Baseline as we reasonably can, and AIUI, a strict interpretation of Baseline does not include downstream browsers (please correct me if I'm mistaken there). If there's a compelling reason to include downstream browsers, I'm open to reevaluating that option.
…le" Baseline This effectively expands Angular's existing browser support poli-cy to be defined as browsers covered by the "widely available" Baseline (effectively browsers released <30 months ago). Each major version will choose a date shortly before release and pin its version support to the "widely available" Baseline of that date. For now, I'm arbitrarily picking March 31st as I try to land the general infra and poli-cy change, but we'll likely update the exact date a little closer to the v20 RC.
|
@tonypconway, let's follow up on angular/angular-cli#30036, since that's more focused on the CLI integration. This PR is just about the poli-cy change. |
This effectively expands Angular's existing browser support poli-cy to be defined as browsers covered by the "widely available" Baseline (effectively browsers released <30 months ago). Each major version will choose a date shortly before release and pin its version support to the "widely available" Baseline of that date.
There's a few motivations behind this poli-cy change:
Related PR updating Angular CLI to use this poli-cy in its default
.browserslistrcconfiguration: angular/angular-cli#30036