docs: Add back script to generate example previews map #60778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
force-pushed
the
fix-adev-preview
branch
11 times, most recently
from
cdb39c9 to
49b178d
Compare
Restores the ability to have example components rendered alongside the code. This functionality was broken a while back by angular#53511. To enable the embedded preview for an example, add `preview` and `path=adev/src/content/expamples/component/to/render.ts` attributes to the `<docs-code>` or `<docs-code-multifile>` tag. Tested with one of the accessibility examples and it seems to work now.
mmalerba
force-pushed
the
fix-adev-preview
branch
from
49b178d to
e8b4673
Compare
mmalerba
changed the title
mmalerba
commented
Apr 10, 2025
Restructures the examples build rules so that all examples are exposed through a single file group in adev/src/content/examples. Also adds a separate filegroup in the same location for just the embeddable examples and adds it to the APPLICATION_FILES for the docs app. This uncovered the fact that some of our examples have broken non-compiling code. I've excluded these ones from being embeddable for now, until the breakages can be addressed
pullapprove
bot
requested review from
alxhub,
jelbourn,
josephperrott and
pkozlowski-opensource
devversion
approved these changes
Apr 10, 2025
mmalerba
force-pushed
the
fix-adev-preview
branch
from
60392bc to
b9c81dd
Compare
pkozlowski-opensource
approved these changes
Apr 11, 2025
jelbourn
approved these changes
Apr 11, 2025
|
This PR was merged into the repository by commit c0ef923. The changes were merged into the following branches: main, 19.2.x |
kirjs
pushed a commit
that referenced
this pull request
Apr 11, 2025
Restructures the examples build rules so that all examples are exposed through a single file group in adev/src/content/examples. Also adds a separate filegroup in the same location for just the embeddable examples and adds it to the APPLICATION_FILES for the docs app. This uncovered the fact that some of our examples have broken non-compiling code. I've excluded these ones from being embeddable for now, until the breakages can be addressed PR Close #60778
kirjs
pushed a commit
that referenced
this pull request
Apr 11, 2025
Restores the ability to have example components rendered alongside the code. This functionality was broken a while back by #53511. To enable the embedded preview for an example, add `preview` and `path=adev/src/content/expamples/component/to/render.ts` attributes to the `<docs-code>` or `<docs-code-multifile>` tag. Tested with one of the accessibility examples and it seems to work now. PR Close #60778
kirjs
pushed a commit
that referenced
this pull request
Apr 11, 2025
Restructures the examples build rules so that all examples are exposed through a single file group in adev/src/content/examples. Also adds a separate filegroup in the same location for just the embeddable examples and adds it to the APPLICATION_FILES for the docs app. This uncovered the fact that some of our examples have broken non-compiling code. I've excluded these ones from being embeddable for now, until the breakages can be addressed PR Close #60778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the ability to have example components rendered alongside the
code. This functionality was broken a while back by #53511.
To enable the embedded preview for an example, add
previewandpath="adev/src/content/expamples/component/to/render.ts"attributes tothe
<docs-code>or<docs-code-multifile>tag.Tested with one of the accessibility examples and it seems to work now.