refactor: use relative FieldPathNodes #60791
Open
+294
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch `apply` behavior to create a brand new root path whenever a new schema is applied. This effectively changes our `FieldPathNode` concept from an absolute path to a relative path. To record how the relative path nodes are connected, introduce a `rootPaths` map to each logic node, and when we `apply`, copy all roots from the sub-schema to the root of the current schema. This results in the top-level schema having a mapping to all roots under it, allowing it to construct the full absolute path. Note: this breaks the current resolve logic, resolve needs to be rewritten to understand the new path structure.
Adds a method to merge one logic node into another. This allows them to be built up separaterly and then joined, instead of always applying rules to the same logic instance.
mmalerba
requested review from
kirjs and
alxhub
and removed request for
AndrewKushnir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
applybehavior to create a brand new root path whenever a new schema is applied. This effectively changes ourFieldPathNodeconcept from an absolute path to a relative path.To record how the relative path nodes are connected, introduce a
rootPathsmap to each logic node, and when weapply, copy all roots from the sub-schema to the root of the current schema. This results in the top-level schema having a mapping to all roots under it, allowing it to construct the full absolute path.