refactor(core): Remove afterRender
#60794
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AfterRenderPhase` enum now becomes private, it isn't exported anymore.
We didn't see solid purposes for this hook that could be replaced with more adequate alternatives: * Native Observers (`MutationObserver`, `ResizeObserver`, `IntersectionObserver`) * `afterRenderEffect` with behaves almost similarly but only if one of its signal depencies has changes * `afterNextRender` when you actually need to schedule it only once.
JeanMeche
changed the title
afterRenderafterRender
|
Guess that also fixes this issue #54825 |
|
If we indeed go in that direction, yes ! We're finishing collecting feedback on that topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't see solid purposes for this developerPreview hook that could be replaced with more adequate alternatives:
MutationObserver,ResizeObserver,IntersectionObserver)afterRenderEffectwith behaves almost similarly but only if one of its signal depencies has changesafterNextRenderwhen you actually need to schedule it only once.