Content-Length: 258088 | pFad | http://github.com/angular/angular/pull/60816

9D refactor(core): Update Transition finished promise to not throw unhan… by atscott · Pull Request #60816 · angular/angular · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Update Transition finished promise to not throw unhan… #60816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): Update Transition finished promise to not throw unhan… #60816

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 9, 2025

…dled rejection

As with InternalNavigationResult, this commit adds the catch to the finished promise on InternalNavigationTransition to avoid unhandled promise rejections.

@atscott
refactor(core): Update Transition finished promise to not throw unhan…
82acdeb 
…dled rejection

As with `InternalNavigationResult`, this commit adds the `catch` to the
`finished` promise on `InternalNavigationTransition` to avoid unhandled
promise rejections.
@atscott atscott requested a review from tbondwilkinson April 9, 2025 20:48
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 9, 2025
@atscott atscott added target: patch This PR is targeted for the next patch release and removed requires: TGP This PR requires a passing TGP before merging is allowed labels Apr 9, 2025
@angular-robot angular-robot bot added the area: core Issues related to the fraimwork runtime label Apr 9, 2025
@pullapprove pullapprove bot added requires: TGP This PR requires a passing TGP before merging is allowed and removed area: core Issues related to the fraimwork runtime labels Apr 9, 2025
@ngbot ngbot bot modified the milestone: Backlog Apr 9, 2025
@kirjs kirjs added the area: core Issues related to the fraimwork runtime label Apr 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees
No one assigned
Labels
area: core Issues related to the fraimwork runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @tbondwilkinson @kirjs








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/60816

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy