fix(compiler-cli): Always retain prior results for all files #61487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: compiler
JoostK
approved these changes
May 20, 2025
|
|
||
| if (existingResults.isComplete) { | ||
| // All data for this file has already been generated, so no need to adopt anything. | ||
| continue; |
There was a problem hiding this comment.
Existing logic so no need to change it now, but this seems suspect to me. If the checker already has state for the source file then it seems incorrect to overwrite that with the old state, without any merging operation. I suspect this logic is irrelevant as no state would be available without having adopted prior results already, at least that's how I'd expect this to work (haven't checked the code)
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded.
atscott
force-pushed
the
adoptAllPriorResult
branch
from
bf3a757 to
e73b99a
Compare
thePunderWoman
approved these changes
May 21, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded. PR Close #61487
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded. PR Close #61487
|
This PR was merged into the repository by commit c71adb1. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded.