fix(common): cancel reader when app is destroyed #61528
Closed
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: common
AndrewKushnir
added
target: patch
JeanMeche
reviewed
May 20, 2025
arturovt
force-pushed
the
fix/common-cancel-reader
branch
from
29aa693 to
17fa299
Compare
JeanMeche
approved these changes
May 21, 2025
Streams left in a pending state (due to `break` without cancel) may continue consuming or holding onto data behind the scenes. Calling `reader.cancel()` allows the browser or the underlying system to release any network or memory resources associated with the stream.
thePunderWoman
force-pushed
the
fix/common-cancel-reader
branch
from
17fa299 to
4a644d1
Compare
thePunderWoman
approved these changes
May 21, 2025
thePunderWoman
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
Streams left in a pending state (due to `break` without cancel) may continue consuming or holding onto data behind the scenes. Calling `reader.cancel()` allows the browser or the underlying system to release any network or memory resources associated with the stream. PR Close #61528
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
Streams left in a pending state (due to `break` without cancel) may continue consuming or holding onto data behind the scenes. Calling `reader.cancel()` allows the browser or the underlying system to release any network or memory resources associated with the stream. PR Close #61528
|
This PR was merged into the repository by commit 17fe731. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams left in a pending state (due to
breakwithout cancel) may continue consuming or holding onto data behind the scenes. Callingreader.cancel()allows the browser or the underlying system to release any network or memory resources associated with the stream.