Content-Length: 300196 | pFad | http://github.com/angular/angular/pull/61535

61 build: migrate forms to rules_js by josephperrott · Pull Request #61535 · angular/angular · GitHub
Skip to content

build: migrate forms to rules_js #61535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: migrate forms to rules_js #61535

wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented May 20, 2025 •
edited
Loading

Looks like my previous change didn't actually change the version stamping as expected as seen here

This should be corrected with this changed.

@josephperrott josephperrott requested a review from devversion May 20, 2025 19:57
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels May 20, 2025
@ngbot ngbot bot modified the milestone: Backlog May 20, 2025
@josephperrott josephperrott added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 20, 2025
@josephperrott
build: migrate forms to rules_js
8100d1e 
Migrate forms to use ng_project and ts_project
@josephperrott
build: update compiler-cli to not be stamped when used for the compil…
22a0af8 
…er in ng_project

The compiler-cli package needs to be unstamped and will the resulting generated code will be stamped as expected.
@josephperrott josephperrott marked this pull request as ready for review May 20, 2025 21:10
@thePunderWoman thePunderWoman removed the request for review from devversion May 21, 2025 09:13
thePunderWoman pushed a commit that referenced this pull request May 21, 2025
@josephperrott @thePunderWoman
build: update compiler-cli to not be stamped when used for the compil…
7f6bb91 
…er in ng_project (#61535)

The compiler-cli package needs to be unstamped and will the resulting generated code will be stamped as expected.

PR Close #61535
thePunderWoman pushed a commit that referenced this pull request May 21, 2025
@josephperrott @thePunderWoman
build: migrate forms to rules_js (#61535)
f6b4602 
Migrate forms to use ng_project and ts_project

PR Close #61535
thePunderWoman pushed a commit that referenced this pull request May 21, 2025
@josephperrott @thePunderWoman
build: update compiler-cli to not be stamped when used for the compil…
3cc0910 
…er in ng_project (#61535)

The compiler-cli package needs to be unstamped and will the resulting generated code will be stamped as expected.

PR Close #61535
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 7f6bb91.

The changes were merged into the following branches: main, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project PullApprove: disable target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @thePunderWoman








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/61535

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy