feat(devtools): update getSignalGraph #61541
Open
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
14 tasks
add a function that we can inspect to jump to the source of a signal, and give every signal a unique id that devtools can use to match signals across calls to getSignalGraph
14 tasks
AleksanderBodurri
approved these changes
May 21, 2025
| let id = signalDebugMap.get(consumer); | ||
| if (!id) { | ||
| counter++; | ||
| id = `${consumer.debugName}-${counter}`; |
There was a problem hiding this comment.
Is there a possibility this becomes undefined-0 or something similar?
There was a problem hiding this comment.
Yes, unnamed signals will become undefined-0 (but will still have a unique ID)
There was a problem hiding this comment.
should we maybe use a nullish coalescing and have unnamed instead of undefined ?
kirjs
approved these changes
May 21, 2025
JeanMeche
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a function that we can inspect to jump to the source of a signal, and give every signal a unique id that devtools can use to match signals across calls to getSignalGraph
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
signals are now given a unique ID using a weakmap, and if they have a user function, we pass that through to the caller so they can call
inspect(debuggableFn)to get chrome to jump to the source of the signal (see #61540 for usage)Does this PR introduce a breaking change?
Other information