Content-Length: 706276 | pFad | http://github.com/angular/angular/pull/61544/files

7E [19.2.x] build: migrate router to use rules_js by josephperrott · Pull Request #61544 · angular/angular · GitHub
Skip to content

[19.2.x] build: migrate router to use rules_js #61544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions goldens/public-api/router/index.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
```ts

import { AfterContentInit } from '@angular/core';
import * as _angular_router from '@angular/router';
import { ChangeDetectorRef } from '@angular/core';
import { ComponentRef } from '@angular/core';
import { ElementRef } from '@angular/core';
Expand Down Expand Up @@ -723,7 +722,7 @@ export class Router {
resetConfig(config: Routes): void;
// @deprecated
routeReuseStrategy: RouteReuseStrategy;
get routerState(): _angular_router.RouterState;
get routerState(): RouterState;
serializeUrl(url: UrlTree): string;
setUpLocationChangeListener(): void;
get url(): string;
Expand Down
1 change: 0 additions & 1 deletion goldens/public-api/router/testing/index.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
```ts

import { AfterContentInit } from '@angular/core';
import * as _angular_router from '@angular/router';
import { ChangeDetectorRef } from '@angular/core';
import { ComponentFixture } from '@angular/core/testing';
import { ComponentRef } from '@angular/core';
Expand Down
15 changes: 9 additions & 6 deletions packages/router/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_module", "ng_package")
load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_package")
load("//tools:defaults2.bzl", "ng_project")

package(default_visibility = ["//visibility:public"])

ng_module(
ng_project(
name = "router",
srcs = glob(
[
"*.ts",
"src/**/*.ts",
],
),
deps = [
interop_deps = [
"//packages/common",
"//packages/core",
"//packages/platform-browser",
"@npm//@types/dom-view-transitions",
"@npm//rxjs",
],
deps = [
"//:node_modules/@types/dom-view-transitions",
"//:node_modules/rxjs",
"//packages/core:core_rjs",
],
)

Expand Down
25 changes: 14 additions & 11 deletions packages/router/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library", "zone_compatible_jasmine_node_test")
load("//tools:defaults.bzl", "karma_web_test_suite", "zone_compatible_jasmine_node_test")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "test_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
# Visible to //:saucelabs_unit_tests_poc target
visibility = ["//:__pkg__"],
deps = [
interop_deps = [
"//packages/common",
"//packages/common/testing",
"//packages/core",
"//packages/core/rxjs-interop",
"//packages/core/testing",
"//packages/platform-browser",
"//packages/platform-browser-dynamic",
"//packages/platform-browser/testing",
"//packages/private/testing",
"//packages/router",
"//packages/router/testing",
"@npm//rxjs",
],
# Visible to //:saucelabs_unit_tests_poc target
visibility = ["//:__pkg__"],
deps = [
"//:node_modules/rxjs",
"//packages/core:core_rjs",
"//packages/core/rxjs-interop:rxjs-interop_rjs",
"//packages/core/testing:testing_rjs",
"//packages/router:router_rjs",
"//packages/router/testing:testing_rjs",
],
)

Expand Down
12 changes: 8 additions & 4 deletions packages/router/test/bootstrap.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@
* found in the LICENSE file at https://angular.dev/license
*/

import {DOCUMENT, PlatformLocation, ɵgetDOM as getDOM} from '@angular/common';
import {BrowserPlatformLocation} from '@angular/common/src/location/platform_location';
import {NullViewportScroller, ViewportScroller} from '@angular/common/src/viewport_scroller';
import {
DOCUMENT,
PlatformLocation,
ɵgetDOM as getDOM,
BrowserPlatformLocation,
ɵNullViewportScroller as NullViewportScroller,
ViewportScroller,
} from '@angular/common';
import {MockPlatformLocation} from '@angular/common/testing';
import {
ApplicationRef,
Expand All @@ -24,7 +29,6 @@ import {TestBed} from '@angular/core/testing';
import {BrowserModule} from '@angular/platform-browser';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {
Event,
NavigationEnd,
provideRouter,
Router,
Expand Down
2 changes: 1 addition & 1 deletion packages/router/test/integration/lazy_loading.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.dev/license
*/
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {LocationStrategy, HashLocationStrategy, Location} from '@angular/common';
import {
inject as coreInject,
Expand Down
2 changes: 1 addition & 1 deletion packages/router/test/integration/route_data.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
} from '../../src';
import {map} from 'rxjs/operators';
import {EMPTY, Observer, Observable, of} from 'rxjs';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {
createRoot,
RootCmp,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
} from '../../src';
import {Subscription} from 'rxjs';
import {filter} from 'rxjs/operators';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {
createRoot,
BlankCmp,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {Component, NgZone} from '@angular/core';
import {Location} from '@angular/common';
import {fakeAsync, TestBed, inject} from '@angular/core/testing';
import {Router, provideRouter} from '../../src';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {
createRoot,
RootCmp,
Expand Down
2 changes: 1 addition & 1 deletion packages/router/test/integration/router_links.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import {Component} from '@angular/core';
import {Location} from '@angular/common';
import {fakeAsync, TestBed, inject, ComponentFixture} from '@angular/core/testing';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {Router} from '../../src';
import {expect} from '@angular/platform-browser/testing/src/matchers';
import {
Expand Down
17 changes: 10 additions & 7 deletions packages/router/testing/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
load("//tools:defaults.bzl", "generate_api_docs", "ng_module")
load("//tools:defaults.bzl", "generate_api_docs")
load("//tools:defaults2.bzl", "ng_project")

package(default_visibility = ["//visibility:public"])

exports_files(["package.json"])

ng_module(
ng_project(
name = "testing",
srcs = glob(["**/*.ts"]),
deps = [
interop_deps = [
"//packages/common",
"//packages/common/testing",
"//packages/core",
"//packages/core/testing",
"//packages/router",
"@npm//rxjs",
],
deps = [
"//:node_modules/rxjs",
"//packages/core:core_rjs",
"//packages/core/testing:testing_rjs",
"//packages/router:router_rjs",
],
)

Expand Down
23 changes: 13 additions & 10 deletions packages/router/testing/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "test_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
# Visible to //:saucelabs_unit_tests_poc target
visibility = ["//:__pkg__"],
deps = [
interop_deps = [
"//packages/common",
"//packages/common/testing",
"//packages/core",
"//packages/core/testing",
"//packages/platform-browser",
"//packages/platform-browser-dynamic",
"//packages/platform-browser/testing",
"//packages/private/testing",
"//packages/router",
"//packages/router/testing",
"@npm//rxjs",
],
# Visible to //:saucelabs_unit_tests_poc target
visibility = ["//:__pkg__"],
deps = [
"//:node_modules/rxjs",
"//packages/core:core_rjs",
"//packages/core/testing:testing_rjs",
"//packages/router:router_rjs",
"//packages/router/testing:testing_rjs",
],
)

Expand Down
15 changes: 9 additions & 6 deletions packages/router/upgrade/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,22 +1,25 @@
load("//tools:defaults.bzl", "generate_api_docs", "ng_module")
load("//tools:defaults.bzl", "generate_api_docs")
load("//tools:defaults2.bzl", "ng_project")

package(default_visibility = ["//visibility:public"])

exports_files(["package.json"])

ng_module(
ng_project(
name = "upgrade",
srcs = glob(
[
"*.ts",
"src/**/*.ts",
],
),
deps = [
interop_deps = [
"//packages/common",
"//packages/core",
"//packages/router",
"//packages/upgrade/static",
],
deps = [
"//packages/core:core_rjs",
"//packages/router:router_rjs",
"//packages/upgrade/static:static_rjs",
],
)

Expand Down
21 changes: 12 additions & 9 deletions packages/router/upgrade/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "test_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
deps = [
interop_deps = [
"//packages/common",
"//packages/common/testing",
"//packages/common/upgrade",
"//packages/core",
"//packages/core/testing",
"//packages/private/testing",
"//packages/router",
"//packages/router/testing",
"//packages/router/upgrade",
"//packages/upgrade/static",
],
deps = [
"//packages/core:core_rjs",
"//packages/core/testing:testing_rjs",
"//packages/router:router_rjs",
"//packages/router/testing:testing_rjs",
"//packages/router/upgrade:upgrade_rjs",
"//packages/upgrade/static:static_rjs",
],
)

Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/61544/files

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy