Migrate to LogicNodeBuilder & LogicNode #62220
Merged
+590
−322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
area: forms
target: feature
mmalerba
force-pushed
the
sf/logic-builder-2
branch
from
d0d6aa8 to
f9eb136
Compare
kirjs
approved these changes
Jun 26, 2025
mmalerba
merged commit 92e7a45
into
angular:prototype/signal-forms
11 of 18 checks passed
github-project-automation
bot
moved this from In Progress
to Done
in Experimental Signal Forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the newly added LogicNodeBuilder & LogicNode which support recursive logic. Key changes:
FieldNodeLogicand replaces it withLogicNodeBuilder/LogicNoderesolveis implemented to support recursive logicBoundPredicateconcept that is aware of its level in the field tree (needed to match it with the correct field in a recursively applied logic node)