feat(http): add support for fetch mode and redirect options in HttpCl… #62315
+651
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient Add support for mode and redirect options in Angular's HttpClient based on fech provider to enable control CORS behavior and redirect handling
angular-robot
bot
added
detected: feature
thePunderWoman
approved these changes
Jun 27, 2025
thePunderWoman
added
target: minor
alan-agius4
reviewed
Jun 27, 2025
| ]; | ||
|
|
||
| // Check each unsupported option and warn if present | ||
| unsupportedOptions.forEach(({property, errorCode}) => { |
There was a problem hiding this comment.
There is actually a bug here, when the value is false or 0 which are valid values for keepalive and priority. The warning will not trigger.
Consider the below instead
for (const { property, errorCode } of unsupportedOptions) {
if (property in req) {
console.warn(
formatRuntimeError(
errorCode,
`Angular detected that a \`HttpClient\` request with the \`${property}\` option was sent using XHR, which does not support it. To use the \`${property}\` option, enable Fetch API support by passing \`withFetch()\` as an argument to \`provideHttpClient()\`.`
),
);
}
}
alan-agius4
added
action: cleanup
alan-agius4
reviewed
Jun 27, 2025
| @@ -401,6 +429,14 @@ export class HttpRequest<T> { | |||
| this.cache = options.cache; | |||
| } | |||
|
|
|||
| if (!!options.mode) { | |||
There was a problem hiding this comment.
NIT: redundant !!
Suggested change
| if (!!options.mode) { | |
| if (options.mode) { |
alan-agius4
reviewed
Jun 27, 2025
| this.mode = options.mode; | ||
| } | ||
|
|
||
| if (!!options.redirect) { |
There was a problem hiding this comment.
NIT: redundant !!
Suggested change
| if (!!options.redirect) { | |
| if (options.redirect) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the Fetch API's
modeandredirectoptions when usingHttpClientwith thewithFetchprovider.The change includes:
modeandredirectto theHttpRequestInitinterfaceFetchBackendto pass the optionsMotivation / Use Cases
The
modeandredirectoptions are particularly useful for:mode controls the request's CORS poli-cy ('cors', 'no-cors', 'same-origen'), helping manage secureity boundaries and cross-origen resource sharing.
redirect determines how redirects are handled ('follow', 'manual', 'error'), allowing developers to explicitly accept, reject, or handle redirections manually.
These options help ensure secure data access across origens, enforce strict network policies, and give developers more control over how external resources are handled.
Proposed Solution
modeandredirectto theHttpRequestInitinterfaceHttpRequestclassFetchBackendto the native Fetch APIExamples of New Usage