More concrete error message test

apache · Apr 24, 2024 · 76cdc62 · 76cdc62
1 parent 9b906aa
commit 76cdc62
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestScanContext.java b/flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestScanContext.java
@@ -30,7 +30,7 @@ void testIncrementalFromSnapshotId() {
                     .streaming(true)
                     .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_ID)
                     .build())
-        .hasMessageContaining("Invalid starting snapshot id for")
+        .hasMessage("Invalid starting snapshot id for SPECIFIC_START_SNAPSHOT_ID strategy: null")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(
@@ -41,7 +41,7 @@ void testIncrementalFromSnapshotId() {
                     .startSnapshotId(1L)
                     .startSnapshotTimestamp(1L)
                     .build())
-        .hasMessageContaining("Invalid starting snapshot timestamp for")
+        .hasMessage("Invalid starting snapshot timestamp for SPECIFIC_START_SNAPSHOT_ID strategy: not null")
         .isInstanceOf(IllegalArgumentException.class);
   }
 
@@ -53,7 +53,7 @@ void testIncrementalFromSnapshotTimestamp() {
                     .streaming(true)
                     .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_TIMESTAMP)
                     .build())
-        .hasMessageContaining("Invalid starting snapshot timestamp for")
+        .hasMessage("Invalid starting snapshot timestamp for SPECIFIC_START_SNAPSHOT_TIMESTAMP strategy: null")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(
@@ -64,58 +64,57 @@ void testIncrementalFromSnapshotTimestamp() {
                     .startSnapshotId(1L)
                     .startSnapshotTimestamp(1L)
                     .build())
-        .hasMessageContaining("Invalid starting snapshot id for")
+        .hasMessage("Invalid starting snapshot id for SPECIFIC_START_SNAPSHOT_ID strategy: not null")
         .isInstanceOf(IllegalArgumentException.class);
   }
 
   @Test
   void testStreaming() {
     Assertions.assertThatThrownBy(() -> ScanContext.builder().streaming(true).useTag("tag").build())
-        .hasMessageContaining("Cannot scan table using ref")
-        .hasMessageContaining("for streaming reader")
+        .hasMessage("Cannot scan table using ref tag configured for streaming reader")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().streaming(true).useSnapshotId(1L).build())
-        .hasMessageContaining("Cannot set snapshot-id option for streaming reader")
+        .hasMessage("Cannot set snapshot-id option for streaming reader")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().streaming(true).asOfTimestamp(1L).build())
-        .hasMessageContaining("Cannot set as-of-timestamp option for streaming reader")
+        .hasMessage("Cannot set as-of-timestamp option for streaming reader")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().streaming(true).endSnapshotId(1L).build())
-        .hasMessageContaining("Cannot set end-snapshot-id option for streaming reader")
+        .hasMessage("Cannot set end-snapshot-id option for streaming reader")
         .isInstanceOf(IllegalArgumentException.class);
 
     Assertions.assertThatThrownBy(() -> ScanContext.builder().streaming(true).endTag("tag").build())
-        .hasMessageContaining("Cannot set end-tag option for streaming reader")
+        .hasMessage("Cannot set end-tag option for streaming reader")
         .isInstanceOf(IllegalArgumentException.class);
   }
 
   @Test
   void testStartConflict() {
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().startTag("tag").startSnapshotId(1L).build())
-        .hasMessageContaining("START_SNAPSHOT_ID and START_TAG cannot both be set.")
+        .hasMessage("START_SNAPSHOT_ID and START_TAG cannot both be set.")
         .isInstanceOf(IllegalArgumentException.class);
   }
 
   @Test
   void testEndConflict() {
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().endTag("tag").endSnapshotId(1L).build())
-        .hasMessageContaining("END_SNAPSHOT_ID and END_TAG cannot both be set.")
+        .hasMessage("END_SNAPSHOT_ID and END_TAG cannot both be set.")
         .isInstanceOf(IllegalArgumentException.class);
   }
 
   @Test
   void testMaxAllowedPlanningFailures() {
     Assertions.assertThatThrownBy(
             () -> ScanContext.builder().maxAllowedPlanningFailures(-2).build())
-        .hasMessageContaining("annot set maxAllowedPlanningFailures to a negative number")
+        .hasMessage("Cannot set maxAllowedPlanningFailures to a negative number other than -1.")
         .isInstanceOf(IllegalArgumentException.class);
   }
 }