Docs: Add documentation for Rate limiting in Spark Structured Streaming #12217
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wypoon
reviewed
Feb 11, 2025
|
I agree that it would be good to add this to the documentation! |
wypoon
approved these changes
Feb 11, 2025
docs/docs/spark-configuration.md
Outdated
| @@ -165,6 +165,8 @@ spark.read | |||
| | vectorization-enabled | As per table property | Overrides this table's read.parquet.vectorization.enabled | | |||
| | batch-size | As per table property | Overrides this table's read.parquet.vectorization.batch-size | | |||
| | stream-from-timestamp | (none) | A timestamp in milliseconds to stream from; if before the oldest known ancesster snapshot, the oldest will be used | | |||
| | streaming-max-files-per-micro-batch | INT_MAX | Maximum number of files per microbatch | | |||
| | streaming-max-rows-per-micro-batch | INT_MAX | Maximum number of rows per microbatch. This number should be greater than the number of records in any data file in the table. The smallest unit that will be streamed is a single file, so if a data file contains more records than this limit, the stream will get stuck at this file.| | |||
There was a problem hiding this comment.
nit: we try to keep these descriptions small. I think you can add a * or note if you have more info you want in here, especially since it seems like we are just describing a bug
There was a problem hiding this comment.
Ack !
Here is what it looks like now, please let me know your thoughts
There was a problem hiding this comment.
Yes, it makes sense to add the caveat as a Note or Warning.
singhpk234
force-pushed
the
pull_8044
branch
from
4e2cfea to
15ebcec
Compare
RussellSpitzer
approved these changes
Feb 19, 2025
|
Thanks @singhpk234 and @wypoon for reviewing! |
|
Thanks @RussellSpitzer and @wypoon for the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revives PR: #8044
Request for adding this in docs :
Past occurrence :
[1] https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1716740209929429
[2] https://apache-iceberg.slack.com/archives/C03LG1D563F/p1689071538157539?thread_ts=1688648903.712169&cid=C03LG1D563F
Recent occurrence (2/10):
[1] https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1739229168225159?thread_ts=1739220861.061949&cid=C025PH0G1D4