[isort] Only infer subpackages of namespace packages as first-party
#16565
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylwil3
added
bug
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| I001 | 1458 | 1446 | 12 | 0 | 0 |
| TC002 | 51 | 51 | 0 | 0 | 0 |
| TC001 | 51 | 0 | 51 | 0 | 0 |
| F401 | 4 | 2 | 2 | 0 | 0 |
| ANN001 | 2 | 1 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1501 -67 violations, +0 -0 fixes in 9 projects; 46 projects unchanged)
Snowflake-Labs/snowcli (+10 -12 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
+ scripts/cleanup.py:14:1: I001 [*] Import block is un-sorted or un-formatted - src/snowflake/cli/_plugins/connection/util.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/_plugins/nativeapp/sf_sql_facade.py:14:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/_plugins/spcs/compute_pool/manager.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/_plugins/spcs/image_repository/manager.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/_plugins/stage/diff.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/api/cli_global_context.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/api/connections.py:15:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/api/entities/common.py:1:1: I001 [*] Import block is un-sorted or un-formatted + src/snowflake/cli/api/sql_execution.py:15:1: I001 [*] Import block is un-sorted or un-formatted ... 12 additional changes omitted for project
apache/airflow (+1435 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
+ clients/python/test_python_client.py:27:1: I001 [*] Import block is un-sorted or un-formatted + dev/perf/dags/elastic_dag.py:17:1: I001 [*] Import block is un-sorted or un-formatted + dev/perf/dags/perf_dag_1.py:22:1: I001 [*] Import block is un-sorted or un-formatted + dev/perf/dags/perf_dag_2.py:22:1: I001 [*] Import block is un-sorted or un-formatted + dev/perf/dags/sql_perf_dag.py:17:1: I001 [*] Import block is un-sorted or un-formatted + docs/apache-airflow/empty_plugin/empty_plugin.py:20:1: I001 [*] Import block is un-sorted or un-formatted + docs/docker-stack/docker-examples/extending/embedding-dags/test_dag.py:20:1: I001 [*] Import block is un-sorted or un-formatted + kubernetes_tests/test_kubernetes_pod_operator.py:17:1: I001 [*] Import block is un-sorted or un-formatted + performance/src/performance_dags/performance_dag/performance_dag.py:42:1: I001 [*] Import block is un-sorted or un-formatted + providers/airbyte/tests/system/airbyte/example_airbyte_trigger_job.py:20:1: I001 [*] Import block is un-sorted or un-formatted + providers/airbyte/tests/unit/airbyte/hooks/test_airbyte.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/airbyte/tests/unit/airbyte/operators/test_airbyte.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/airbyte/tests/unit/airbyte/sensors/test_airbyte.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/airbyte/tests/unit/airbyte/triggers/test_airbyte.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/system/alibaba/example_adb_spark_batch.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/system/alibaba/example_adb_spark_sql.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/system/alibaba/example_oss_bucket.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/system/alibaba/example_oss_object.py:17:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/unit/alibaba/cloud/hooks/test_analyticdb_spark.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/unit/alibaba/cloud/hooks/test_oss.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/unit/alibaba/cloud/log/test_oss_task_handler.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/unit/alibaba/cloud/operators/test_analyticdb_spark.py:18:1: I001 [*] Import block is un-sorted or un-formatted + providers/alibaba/tests/unit/alibaba/cloud/sensors/test_analyticdb_spark.py:18:1: I001 [*] Import block is un-sorted or un-formatted ... 1411 additional changes omitted for rule I001 + providers/weaviate/tests/unit/weaviate/hooks/test_weaviate.py:268:9: ANN201 Missing return type annotation for public function `test_create_object_already_exists_return_none` - providers/weaviate/tests/unit/weaviate/hooks/test_weaviate.py:268:9: ANN201 Missing return type annotation for public function `test_create_object_already_exists_return_none` + tests/decorators/test_setup_teardown.py:73:9: ANN201 Missing return type annotation for public function `test_marking_functions_as_teardown_task` - tests/decorators/test_setup_teardown.py:73:9: ANN201 Missing return type annotation for public function `test_marking_functions_as_teardown_task` ... 1410 additional changes omitted for project
apache/superset (+15 -15 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- tests/integration_tests/dashboards/filter_state/api_tests.py:28:53: TC001 Move application import `superset.commands.temporary_cache.entry.Entry` into a type-checking block + tests/integration_tests/dashboards/filter_state/api_tests.py:28:53: TC002 Move third-party import `superset.commands.temporary_cache.entry.Entry` into a type-checking block - tests/integration_tests/explore/api_tests.py:24:55: TC001 Move application import `superset.commands.explore.form_data.state.TemporaryExploreState` into a type-checking block + tests/integration_tests/explore/api_tests.py:24:55: TC002 Move third-party import `superset.commands.explore.form_data.state.TemporaryExploreState` into a type-checking block - tests/integration_tests/explore/form_data/api_tests.py:25:55: TC001 Move application import `superset.commands.explore.form_data.state.TemporaryExploreState` into a type-checking block + tests/integration_tests/explore/form_data/api_tests.py:25:55: TC002 Move third-party import `superset.commands.explore.form_data.state.TemporaryExploreState` into a type-checking block - tests/integration_tests/fixtures/birth_names_dashboard.py:23:34: TC001 Move application import `superset.models.core.Database` into a type-checking block + tests/integration_tests/fixtures/birth_names_dashboard.py:23:34: TC002 Move third-party import `superset.models.core.Database` into a type-checking block - tests/integration_tests/query_context_tests.py:30:43: TC001 Move application import `superset.common.query_context.QueryContext` into a type-checking block + tests/integration_tests/query_context_tests.py:30:43: TC002 Move third-party import `superset.common.query_context.QueryContext` into a type-checking block ... 20 additional changes omitted for project
bokeh/bokeh (+30 -30 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- tests/integration/models/test_plot.py:27:28: TC001 Move application import `bokeh.document.Document` into a type-checking block + tests/integration/models/test_plot.py:27:28: TC002 Move third-party import `bokeh.document.Document` into a type-checking block - tests/integration/tools/test_box_edit_tool.py:24:49: TC001 Move application import `bokeh.application.handlers.function.ModifyDoc` into a type-checking block + tests/integration/tools/test_box_edit_tool.py:24:49: TC002 Move third-party import `bokeh.application.handlers.function.ModifyDoc` into a type-checking block - tests/integration/tools/test_box_zoom_tool.py:21:30: TC001 Move application import `bokeh.core.enums.DimensionsType` into a type-checking block + tests/integration/tools/test_box_zoom_tool.py:21:30: TC002 Move third-party import `bokeh.core.enums.DimensionsType` into a type-checking block - tests/integration/tools/test_freehand_draw_tool.py:24:49: TC001 Move application import `bokeh.application.handlers.function.ModifyDoc` into a type-checking block + tests/integration/tools/test_freehand_draw_tool.py:24:49: TC002 Move third-party import `bokeh.application.handlers.function.ModifyDoc` into a type-checking block - tests/integration/tools/test_pan_tool.py:21:30: TC001 Move application import `bokeh.core.enums.DimensionsType` into a type-checking block + tests/integration/tools/test_pan_tool.py:21:30: TC002 Move third-party import `bokeh.core.enums.DimensionsType` into a type-checking block ... 50 additional changes omitted for project
freedomofpress/securedrop (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
+ journalist_gui/test_gui.py:1:1: I001 [*] Import block is un-sorted or un-formatted
latchbio/latch (+2 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
- src/latch_cli/services/init/example_conda/__init__.py:10:35: F401 [*] `latch.resources.tasks.small_task` imported but unused; consider removing, adding to `__all__`, or using a redundant alias + src/latch_cli/services/init/example_conda/__init__.py:10:35: F401 `latch.resources.tasks.small_task` imported but unused - src/latch_cli/services/init/example_r/__init__.py:10:35: F401 [*] `latch.resources.tasks.small_task` imported but unused; consider removing, adding to `__all__`, or using a redundant alias + src/latch_cli/services/init/example_r/__init__.py:10:35: F401 `latch.resources.tasks.small_task` imported but unused
mlflow/mlflow (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
+ tests/projects/utils.py:50:5: I001 [*] Import block is un-sorted or un-formatted
zulip/zulip (+6 -6 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- confirmation/models.py:36:9: TC001 Move application import `zilencer.models.PreregistrationRemoteRealmBillingUser` into a type-checking block + confirmation/models.py:36:9: TC002 Move third-party import `zilencer.models.PreregistrationRemoteRealmBillingUser` into a type-checking block - confirmation/models.py:37:9: TC001 Move application import `zilencer.models.PreregistrationRemoteServerBillingUser` into a type-checking block + confirmation/models.py:37:9: TC002 Move third-party import `zilencer.models.PreregistrationRemoteServerBillingUser` into a type-checking block - zerver/lib/request.py:17:33: TC001 Move application import `zilencer.models.RemoteZulipServer` into a type-checking block + zerver/lib/request.py:17:33: TC002 Move third-party import `zilencer.models.RemoteZulipServer` into a type-checking block - zerver/lib/send_email.py:44:33: TC001 Move application import `zilencer.models.RemoteZulipServer` into a type-checking block + zerver/lib/send_email.py:44:33: TC002 Move third-party import `zilencer.models.RemoteZulipServer` into a type-checking block - zilencer/views.py:78:30: TC001 Move application import `zerver.lib.types.RemoteRealmDictValue` into a type-checking block + zilencer/views.py:78:30: TC002 Move third-party import `zerver.lib.types.RemoteRealmDictValue` into a type-checking block ... 2 additional changes omitted for project
... Truncated remaining completed project reports due to GitHub comment length restrictions
Changes by rule (5 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| I001 | 1458 | 1446 | 12 | 0 | 0 |
| TC002 | 51 | 51 | 0 | 0 | 0 |
| TC001 | 51 | 0 | 51 | 0 | 0 |
| ANN201 | 4 | 2 | 2 | 0 | 0 |
| F401 | 4 | 2 | 2 | 0 | 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12987 redux - WIP