[syntax-errors] Improve error message and range for pre-PEP-614 decorator syntax errors #16581
Conversation
AlexWaygood
force-pushed
the
alex/syntax-error-msgs
branch
from
08badbb to
63e2de2
Compare
|
|
@ntBre and I discussed this and we deliberately decided against it because:
I'm not opposed to this change. I just want to make clear that we deliberately decided against it because we wanted to focus our time on higher priority syntax errors and reduce complexity |
| 3 | @await bar | ||
| | ^^^^^^^^^ Syntax Error: Cannot use `await` expression outside function-call arguments in a decorator on Python 3.8 (syntax was added in Python 3.9) |
There was a problem hiding this comment.
I actually find the "outside function-call arguments in a decorator" part a bit confusing because it made me think that this is only allowed in function-call arguments. I'd possibly remove it and keep it simply "Cannot use await expression in a decorator on Python 3.8 ..." but then the message cannot be used in a general way because, in this example, the await expression is only not allowed at the top-level (@(await x)) while @decorator(await x) would be ok.
There was a problem hiding this comment.
Oh, I see. So you interpreted "outside function-call arguments" as meaning "If I add parentheses, it will be valid syntax"?
Hmm, I'm not sure how to clarify that :/ adding the parentheses doesn't make it a function call -- but I can see how a beginner might find the language confusing. Would you find "outside call expression arguments" any clearer?
AlexWaygood
force-pushed
the
alex/syntax-error-msgs
branch
from
b034baf to
4158b95
Compare
Summary
A small followup to #16386. We now tell the user exactly what it was about their decorator that constituted invalid syntax on Python <3.9, and the range now highlights the specific sub-expression that is invalid rather than highlighting the whole decorator
Test Plan
Inline snapshots are updated, and new ones are added.