Content-Length: 247324 | pFad | http://github.com/astral-sh/ruff/pull/16595

72 Factor out shared unpacking logic by ericmarkmartin · Pull Request #16595 · astral-sh/ruff · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out shared unpacking logic #16595

Draft

ericmarkmartin wants to merge 1 commit into astral-sh:main from ericmarkmartin:add-unpack-kind

+204 −176

Contributor

ericmarkmartin commented Mar 10, 2025

Summary

The logic for unpacking in assignment, for loops, and with items are very similar. Let's factor it out into some shared logic.

Test Plan

existing tests


          add unpackable assignments

a912584

AlexWaygood added the red-knot label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

Labels