fix incorrect ordering of intersection #16764
Open
+41
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtshiba
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
AlexWaygood
reviewed
Mar 15, 2025
There was a problem hiding this comment.
Thanks, this looks great! It looks like this change means that the negation_reverses_subtype_order property test now passes consistently; could you move it from the flaky submodule in property_tests.rs to the stable submodule?
I verified that it now passes consistently by running QUICKCHECK_TESTS=2000000 cargo test --release -p red_knot_python_semantic -- --ignored types::property_tests::flaky::negation_reverses_subtype_order, which quickly fails on main but not on this PR branch.
Comment on lines
+26
to
+28
| left: &Type<'db>, | ||
| right: &Type<'db>, | ||
| db: &'db dyn crate::Db, |
There was a problem hiding this comment.
nit: for all other functions and methods in red-knot, db is always the first argument. We should do that here too, for consistency:
Suggested change
| left: &Type<'db>, | |
| right: &Type<'db>, | |
| db: &'db dyn crate::Db, | |
| db: &'db dyn crate::Db, | |
| left: &Type<'db>, | |
| right: &Type<'db>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #16641
As stated in this comment (#16641 (comment)), the current ordering implementation for intersection types is incorrect. So, I will introduce lexicographic ordering for intersection types.
Test Plan
As can be seen here, it appears that the execution time of
red_knot_check_filewill slow down by about 3% when this change is merged. The slow-down itself is unavoidable given that we have been skipping processes that should have been done, but please let me know if there is a better ordering algorithm or some sort of salsa query technique.