Content-Length: 433704 | pFad | http://github.com/astral-sh/ruff/pull/16765

71 Add invalid type expressions. by MatthewMckee4 · Pull Request #16765 · astral-sh/ruff · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalid type expressions. #16765

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add invalid type expressions. #16765

wants to merge 14 commits into from
+55 −8

Conversation

MatthewMckee4
Copy link

Expand InvalidTypeExpression enum to include number, bytes and boolean in type expression

Summary

Fixes #16532

Test Plan

Still need to look into where tests should be put for this improvement

@MatthewMckee4
Add invalid type expressions.
4ade214 
Expand `InvalidTypeExpression` enum to include number, bytes and boolean in type expression
@MatthewMckee4
Copy link
Author

I may be wrong, but it seems that byte literals are already handled here:

ruff/crates/red_knot_python_semantic/src/types/infer.rs

Lines 5445 to 5452 in 44aec36

ast::Expr::BytesLiteral(bytes) => {
self.context.report_lint(
&BYTE_STRING_TYPE_ANNOTATION,
bytes,
format_args!("Type expressions cannot use bytes literal"),
);
TypeAndQualifiers::unknown()
}
.

And tested here:

ruff/crates/red_knot_python_semantic/resources/mdtest/annotations/string.md

Lines 88 to 89 in 44aec36

# error: [byte-string-type-annotation] "Type expressions cannot use bytes literal"
i: "b'int'",

@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Mar 15, 2025
@MatthewMckee4
Copy link
Author

There's now a test failing at

ruff/crates/red_knot_python_semantic/resources/mdtest/annotations/literal.md

Line 141 in ccec364

a1: Literal[26]

I think this is expected though, as the generics are not implemented for SpecialForm i think?

@MatthewMckee4 MatthewMckee4 marked this pull request as ready for review March 16, 2025 12:41
AlexWaygood
AlexWaygood reviewed Mar 16, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think you're mostly on the right track, but there's a few issues here to sort out

AlexWaygood
AlexWaygood reviewed Mar 16, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close!

AlexWaygood
AlexWaygood approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

MatthewMckee4 and others added 2 commits March 16, 2025 22:22
@MatthewMckee4 @AlexWaygood
Update crates/red_knot_python_semantic/src/types/infer.rs
289a212 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@MatthewMckee4 @AlexWaygood
Update crates/red_knot_python_semantic/src/types/infer.rs
7febfd4 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
Copy link
Member

I'll wait until our CI's back up and running before merging this (everything's disabled at the moment due to #16768, we should get it up again tomorrow)

@MatthewMckee4
Copy link
Author

Sounds good, thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] Raise "invalid type expression" error for literal types
2 participants
@MatthewMckee4 @AlexWaygood








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/astral-sh/ruff/pull/16765

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy