[flake8-bandit] Allow raw strings in suspicious-mark-safe-usage (S308) #16702
#16770
+249
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop flagging each invocation of `django.utils.safestring.mark_safe` (also available at, `django.utils.html.mark_safe`) as an error. Instead, allow literal strings as valid uses for `mark_safe`. Also, update the documentation, pointing at `django.utils.html.format_html` for dynamic content generation use cases. I verified several possible uses, but string literals, are still flagged.
mfontanaar
changed the title
suspicious-mark-safe-usage (S308) #16702flake8-bandit] Allow raw strings in suspicious-mark-safe-usage (S308) #16702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stop flagging each invocation of
django.utils.safestring.mark_safe(also available at,django.utils.html.mark_safe) as an error.Instead, allow string literals as valid uses for
mark_safe.Also, update the documentation, pointing at
django.utils.html.format_htmlfor dynamic content generation use cases.Closes #16702
Test Plan
I verified several possible uses, but string literals, are still flagged.