[flake8-tidy-imports
] Implement relative-sibling-imports
(TID254
)
#16772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows the discussion from #1014 and add a new opt-in rule
TID254
which is requiring relative import for sibling (and nested) modules.It requires the
linter.flake8-tidy-imports.relative-sibling-imports
setting to betrue
to avoid users having enabled allTID
to have their imports rewritten if they did not choose to as it is one of 2 suggested PEP8 alternatives:Fixes #1014
Test Plan
Multiple test cases have been added to the test suite, with associated expected snapshots, and it has been tested on some external codebases.