[ruff
] implement IfKeyNotInDictAssign
rule (RUF060)
#16775
+791
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement
IfKeyNotInDictAssign
rule (RUF060)which suggest to use
setdefault
.closes #7897
see also dosisod/refurb#349
Notes
In the implementation:
is_same_arg
/is_same_key
are implemented in a strange (syntactic) way. I think it's worth catching complex expressions here (espessially inarg
case), but can't find the right machinery to structured comparison of it.is_idempotent
/is_cheap_to_evaluate
are implemented in really simple and conservative way, and so have a lot of false negative. We can implement them by usingwalk_expr
machinery instead (e.g. to find function call-s), but I do not have strong opinion here. What do you think, is additional code complexity worth it?Test Plan
cargo test