Content-Length: 303950 | pFad | http://github.com/cake-build/cake/pull/4329

71 Add support for capturing MSBuild properties, items and target results by paulomorgado · Pull Request #4329 · cake-build/cake · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for capturing MSBuild properties, items and target results #4329

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add support for capturing MSBuild properties, items and target results #4329

wants to merge 2 commits into from

Conversation

paulomorgado
Copy link
Contributor

Add support for capturing MSBuild properties, items and target results using Evaluate items and properties and display results of targets.

  • Added StandardOutputAction properties to DotNetCoreMSBuildBuilderFixture and MSBuildRunnerFixture.
  • Updated RunTool methods to pass StandardOutputAction to Build and Run methods.
  • Added new test cases in DotNetMSBuildBuilderTests and MSBuildRunnerTests to verify functionality.
  • Added overloads in DotNetAliases and MSBuildAliases to accept standardOutputAction parameter.
  • Updated DotNetMSBuildBuilder and MSBuildRunner to handle standardOutputAction and configure process settings.
  • Enhanced MSBuildArgumentBuilderExtensions to append MSBuild arguments for properties, items, and target results.
  • Extended DotNetMSBuildSettings and MSBuildSettings with new properties and collections.
  • Added extension methods in DotNetMSBuildSettingsExtensions for fluent configuration.

@paulomorgado paulomorgado force-pushed the MSBuild-GetProperty-GetItem branch from b95922c to 0333fcc Compare August 30, 2024 19:20
@paulomorgado paulomorgado force-pushed the MSBuild-GetProperty-GetItem branch 2 times, most recently from 6a074da to 76a1b2b Compare September 26, 2024 19:12
@paulomorgado
Copy link
Contributor Author

@devlead, is there anything needed here?

@devlead
Copy link
Member

devlead commented Oct 30, 2024

@devlead, is there anything needed here?

Don't know, a the moment just the maintainers' time to get bearings on what's trying to be achieved and review and understand the multiple changes introduced. Meanwhile, answers to most questions about what's expected from PRs and what to expect can be found in our Contribution Guidelines.

@paulomorgado paulomorgado force-pushed the MSBuild-GetProperty-GetItem branch from 76a1b2b to fa9d0c6 Compare December 5, 2024 14:38
@paulomorgado @devlead
Add support for capturing MSBuild properties, items and target results
6a26f31 
Introduce the ability to capture and process the standard output of MSBuild commands in the Cake build automation system.

- Added `StandardOutputAction` properties to `DotNetCoreMSBuildBuilderFixture` and `MSBuildRunnerFixture`.
- Updated `RunTool` methods to pass `StandardOutputAction` to `Build` and `Run` methods.
- Added new test cases in `DotNetMSBuildBuilderTests` and `MSBuildRunnerTests` to verify functionality.
- Added overloads in `DotNetAliases` and `MSBuildAliases` to accept `standardOutputAction` parameter.
- Updated `DotNetMSBuildBuilder` and `MSBuildRunner` to handle `standardOutputAction` and configure process settings.
- Enhanced `MSBuildArgumentBuilderExtensions` to append MSBuild arguments for properties, items, and target results.
- Extended `DotNetMSBuildSettings` and `MSBuildSettings` with new properties and collections.
- Added extension methods in `DotNetMSBuildSettingsExtensions` for fluent configuration.
@devlead devlead force-pushed the MSBuild-GetProperty-GetItem branch from fa9d0c6 to 6a26f31 Compare January 6, 2025 15:11
devlead
devlead requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a lot going on in this pull request, could you add integration tests below for the new bits introduced in this PR
https://github.com/cake-build/cake/blob/develop/tests/integration/Cake.Common/Tools/DotNet/DotNetAliases.cake

@paulomorgado paulomorgado force-pushed the MSBuild-GetProperty-GetItem branch from 657bd71 to 73877eb Compare January 6, 2025 18:45
@paulomorgado paulomorgado force-pushed the MSBuild-GetProperty-GetItem branch from 73877eb to b085967 Compare January 6, 2025 18:57
@paulomorgado
Copy link
Contributor Author

There’s a lot going on in this pull request, could you add integration tests below for the new bits introduced in this PR https://github.com/cake-build/cake/blob/develop/tests/integration/Cake.Common/Tools/DotNet/DotNetAliases.cake

Done, @devlead!

Please, check if it's enough. I don't want the tests to become too brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Response from Cake team required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulomorgado @devlead








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/cake-build/cake/pull/4329

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy