Stevenmasley/debugging e2e #19068
Open
Stevenmasley/debugging e2e #19068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updateWorkspace tests were written for the classic parameter flow. With dynamic parameters now being the default, these tests need to explicitly disable dynamic parameters via the template settings page to continue working as expected. This fix: 1. Adds a disableDynamicParameters helper function 2. Modifies all updateWorkspace tests to disable dynamic parameters after template creation 3. Ensures tests use the classic parameter flow they were designed for Fixes the failing e2e test 'update workspace with ephemeral parameter enabled'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.